Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using google_project.id as an input across the provider #10927

Open
slevenick opened this issue Jan 18, 2022 · 1 comment
Open

Allow using google_project.id as an input across the provider #10927

slevenick opened this issue Jan 18, 2022 · 1 comment

Comments

@slevenick
Copy link
Collaborator

slevenick commented Jan 18, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

We have seen several issues where users use the standard id field from google_project as an input into other resources. The issue is that id for this resource is in the normal ID format, which is projects/{{project}} while most resources expect the project as only {{project}}.

We should make resources accept the project as both {{project}} and projects/{{project}} to allow for use of both google_project.id and google_project.project_id. This will be a change across many resources

New or Affected Resource(s)

  • google_*

Most resources that use projects

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.

References

@rileykarson
Copy link
Collaborator

rileykarson commented Jan 24, 2022

Note: We can likely restrict to "known" projects, i.e. fields named exactly "project" or cases that call getProject

@rileykarson rileykarson added this to the Goals milestone Jan 24, 2022
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Jun 11, 2024
…e and outlier_detection in backend_service and regional_backend_service before changing defaults (hashicorp#10927)

[upstream:d1808d2885870f080ceb1cc58c567baedf07f94f]

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Jun 11, 2024
…e and outlier_detection in backend_service and regional_backend_service before changing defaults (#10927) (#18399)

[upstream:d1808d2885870f080ceb1cc58c567baedf07f94f]

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants