Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy_config missing from google_container_aws_node_pool resource #11487

Labels
enhancement forward/review In review; remove label to forward service/gkemulticloud size/s tpgtools Issues related to the tpgtools generator
Milestone

Comments

@stephenmuss
Copy link

stephenmuss commented Apr 13, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The proxy_config argument of the config block in the google_container_aws_node_pool resource is missing. This is possible to specify for google_container_aws_cluster but missing from node pools.

New or Affected Resource(s)

  • google_container_aws_node_pool

Potential Terraform Configuration

This should be the same as it is for google_container_aws_cluster.

proxy_config {
  secret_arn     = "arn:aws:secretsmanager:us-west-2:126285863215:secret:proxy_config20210824150329476300000001-ABCDEF"
  secret_version = "12345678-ABCD-EFGH-IJKL-987654321098"
}

Related

This looks like it was added to the declarative-resource-client-library a few weeks ago: GoogleCloudPlatform/declarative-resource-client-library@d727244 which made release v1.3.0

@rileykarson rileykarson added size/s tpgtools Issues related to the tpgtools generator labels Apr 18, 2022
@rileykarson rileykarson added this to the Goals milestone Apr 18, 2022
@hdp617
Copy link

hdp617 commented Apr 21, 2022

Hi @stephenmuss, support for AWS node pool proxy config was added to the declarative-resource-client-library and released in v.1.3.0 as you mentioned. We're working on bumping the declarative-resource-client-library to v.1.3.0 [0].

cc: @bkauf.

[0] GoogleCloudPlatform/magic-modules#5902

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
@github-actions github-actions bot added forward/review In review; remove label to forward service/gkemulticloud labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement forward/review In review; remove label to forward service/gkemulticloud size/s tpgtools Issues related to the tpgtools generator
Projects
None yet
3 participants