Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

This PR includes the changes in:
GoogleCloudPlatform/magic-modules#5936
GoogleCloudPlatform/magic-modules#5902

Fixes hashicorp/terraform-provider-google#10873
Fixes hashicorp/terraform-provider-google#10297
Fixes hashicorp/terraform-provider-google#11487

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `service_directory_registrations` to `google_compute_forwarding_rule` resource
containeraws: added `proxy_config` to `google_container_aws_node_pool` resource
containerazure: added `proxy_config` to `google_container_azure_node_pool` resource
containeraws: added `instance_placement` and `logging_config` to `google_container_aws_cluster` resource (beta)
containeraws: added `image_type` and `instance_placement` to `google_container_aws_node_pool` resource (beta)
containerazure: added `logging_config` to `google_container_azure_cluster` resource (beta)
containerazure: added `image_type` to `google_container_azure_node_pool` resource (beta)

Derived from GoogleCloudPlatform/magic-modules#5994

* dcl upgrade + proxy_config test

* run make serialize

* added more multicloud tests

* added forwarding_rule tests + doc and exclude service_directory_registrations from global_forwarding_rule

* fix tests

* run make serialize

* fix forwarding_rule test

* added EXCLUDE to beta file

* update test + hide beta example + exclude containeraws proxy_config

* upgrade dcl to 1.5.1

* added proxy_config test

* remove EXCLUDE tag

* fix test

* format

* remove require

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner May 3, 2022 23:04
@modular-magician modular-magician requested review from iyabchen and removed request for a team May 3, 2022 23:04
@modular-magician modular-magician merged commit 2058feb into GoogleCloudPlatform:main May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant