Added service_directory_registrations to forwarding_rule resource

[richard-mealey]

DESCRIPTION: Added service_directory_registrations to compute-forwarding_rule resource

References to issues:

Fixes hashicorp/terraform-provider-google#10873

fixes [http://b/224815162] DT: (t-g) Forwarding Rule Support for google_compute_forwarding_rule serviceDirectoryRegistrations #MultiMediaLLC
part of [http://b/213945697] (t-g) Forwarding Rule Support for serviceDirectoryRegistrations #MultiMediaLLC

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `service_directory_registrations` field to resource `google_compute_forwarding_rule` (beta)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

[trodge]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 438 insertions(+), 138 deletions(-))
Terraform Beta: Diff ( 11 files changed, 779 insertions(+), 151 deletions(-))
TF Validator: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1982
Passed tests 1698
Skipped tests: 240
Failed tests: 44

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRoute_routeIlbExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleForwardingRule

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleForwardingRule[view]
TestAccComputeGlobalForwardingRule_labels[view]
TestAccComputeVpnTunnel_defaultTrafficSelectors[view]
TestAccComputeVpnTunnel_regionFromGateway[view]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[view]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[view]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[view]
TestAccComputeRouterInterface_basic[view]
TestAccComputeRoute_routeIlbVipExample[view]
TestAccComputeRoute_routeIlbExample[view]
TestAccComputePacketMirroring_computePacketMirroringFullExample[view]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[view]
TestAccComputeForwardingRule_ip[view]
TestAccComputeGlobalForwardingRule_ipv6[view]
TestAccComputeGlobalForwardingRule_updateTarget[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[view]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[view]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[view]
TestAccComputeForwardingRule_networkTier[view]
TestAccComputeForwardingRule_forwardingRuleBasicExample[view]
TestAccComputeForwardingRule_update[view]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[view]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[view]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[view]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[view]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[view]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[view]
TestAccDataSourceGoogleGlobalForwardingRule[view]

Tests failed during RECORDING mode:
TestAccComputeVpnTunnel_router[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[view]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[view]
TestAccComputeRouterInterface_withTunnel[view]
TestAccComputeRouterPeer_bfd[view]
TestAccComputeRouterPeer_enable[view]
TestAccComputeRouterPeer_advertiseMode[view]
TestAccComputeRouterPeer_basic[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 438 insertions(+), 138 deletions(-))
Terraform Beta: Diff ( 11 files changed, 779 insertions(+), 151 deletions(-))
TF Validator: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1982
Passed tests 1730
Skipped tests: 240
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeVpnTunnel_router|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]

Tests failed during RECORDING mode:
TestAccComputeRouterInterface_withTunnel[view]
TestAccComputeVpnTunnel_router[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[view]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[view]
TestAccComputeRouterPeer_advertiseMode[view]
TestAccComputeRouterPeer_bfd[view]
TestAccComputeRouterPeer_enable[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccComputeRouterPeer_basic[view]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[shuyama1]

The website docs of this resource is generated via mmv1. Therefore we still need to add the fields to mmv1 to generate docs. Here is the link to the google_compute_forwarding_rule resource:

magic-modules/mmv1/products/compute/api.yaml

Line 3745 in 03ca846

- !ruby/object:Api::Resource

Here is the guidance and the example on making changes to resources.
Please let me know if you have any questions adding the fields in mmv1. Sorry for the extra work! Thanks!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 546 insertions(+), 229 deletions(-))
Terraform Beta: Diff ( 12 files changed, 859 insertions(+), 233 deletions(-))
TF Validator: Diff ( 3 files changed, 48 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 454 insertions(+), 140 deletions(-))
Terraform Beta: Diff ( 12 files changed, 770 insertions(+), 147 deletions(-))
TF Validator: Diff ( 3 files changed, 48 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1991
Passed tests 1731
Skipped tests: 240
Failed tests: 20

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_router|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeRoute_routeIlbVipExample[view]
TestAccComputeRoute_routeIlbExample[view]
TestAccComputePacketMirroring_computePacketMirroringFullExample[view]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[view]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[view]

Tests failed during RECORDING mode:
TestAccComputeRouterPeer_advertiseMode[view]
TestAccComputeVpnTunnel_router[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[view]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[view]
TestAccComputeRouterInterface_withTunnel[view]
TestAccComputeRouterPeer_bfd[view]
TestAccComputeRouterPeer_enable[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccComputeRouterPeer_basic[view]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[view]
TestAccComputeForwardingRule_update[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[richard-mealey]

The website docs of this resource is generated via mmv1. Therefore we still need to add the fields to mmv1 to generate docs. Here is the link to the google_compute_forwarding_rule resource:

magic-modules/mmv1/products/compute/api.yaml

Line 3745 in 03ca846

- !ruby/object:Api::Resource

Here is the guidance and the example on making changes to resources. Please let me know if you have any questions adding the fields in mmv1. Sorry for the extra work! Thanks!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 554 insertions(+), 150 deletions(-))
Terraform Beta: Diff ( 16 files changed, 893 insertions(+), 157 deletions(-))
TF Validator: Diff ( 3 files changed, 48 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1992
Passed tests 1717
Skipped tests: 241
Failed tests: 34

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRouterInterface_basic|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_update|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccDataSourceGoogleForwardingRule

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleForwardingRule[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeVpnTunnel_defaultTrafficSelectors[view]
TestAccComputeVpnTunnel_regionFromGateway[view]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[view]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[view]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[view]
TestAccComputeRouterInterface_basic[view]
TestAccComputeRoute_routeIlbVipExample[view]
TestAccComputeRoute_routeIlbExample[view]
TestAccComputePacketMirroring_computePacketMirroringFullExample[view]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[view]
TestAccComputeGlobalForwardingRule_labels[view]
TestAccComputeGlobalForwardingRule_ipv6[view]
TestAccComputeGlobalForwardingRule_updateTarget[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[view]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[view]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[view]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[view]
TestAccComputeForwardingRule_networkTier[view]
TestAccComputeForwardingRule_ip[view]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[view]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[view]
TestAccComputeForwardingRule_forwardingRuleBasicExample[view]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[view]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[view]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[view]
TestAccDataSourceGoogleGlobalForwardingRule[view]

Tests failed during RECORDING mode:
TestAccComputeForwardingRule_update[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 14 files changed, 618 insertions(+), 150 deletions(-))
Terraform Beta: Diff ( 16 files changed, 933 insertions(+), 155 deletions(-))
TF Validator: Diff ( 3 files changed, 48 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1994
Passed tests 1751
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_serviceDirectoryRegistrations

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[view]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[view]

All tests passed
View the build log or the debug log for each test

[shuyama1]

The changes in this PR are added in #5994. Therefore, I will close this PR.