Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection_id field to bigquery table external_data_configuration #11741

Closed
gutschenritter opened this issue May 20, 2022 · 6 comments
Closed

Comments

@gutschenritter
Copy link

gutschenritter commented May 20, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

The bigquery connection resource type cloud_resource was recently added in #6020. In order to support Big Lake, connection resources should be able to be used on table creation and update, as a member of the external data config.

New or Affected Resource(s)

  • google_bigquery_table

Potential Terraform Configuration

resource "google_bigquery_table" "my-table-resource" {
  dataset_id = google_bigquery_dataset.dataset.dataset_id
  table_id   = "my-table"
  project = "my-project"

  schema = <<EOF
[
  {
    "name": "foo",
    "type": "STRING"
  }
]
EOF

  external_data_configuration {
    source_format = "PARQUET"
    connection_id = google_bigquery_connection.connection.name
    source_uris = [
      "gs://my-uri/*.parquet",
    ]
  }

}

References

  • #0000
@gutschenritter
Copy link
Author

I'm working on this right now.

@gutschenritter
Copy link
Author

@DrFaust92
Copy link
Contributor

rileykarson this can be closed

@sanghaniJ
Copy link
Contributor

b/263756506

@sanghaniJ
Copy link
Contributor

I've gone through this issue and it seems like the support for connection_id is already added. Here is the link of the Pull Request that was merged. Hence, closing this issue ticket.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants