Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bigquery connection of type CLOUD_RESOURCE & make other examples GA. #6020

Conversation

gutschenritter
Copy link
Contributor

Add connection of type cloud_resource to google_bigquery_connection. Fixes hashicorp/terraform-provider-google#11671

If this PR is for Terraform, I acknowledge that I have:

  • [ X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery connection: Added connection of type cloud_resource for `google_bigquery_connection`
bigquery connection: Made `google_bigquery_connection` part of GA terraform provider.

@gutschenritter
Copy link
Contributor Author

make lint failed but none of the products it failed for were bigquery connection.

Saw errors like these:

==> Checking source code against linters...
google/config.go:25:2: `v2` redeclared in this block (typecheck)
	"google.golang.org/api/bigtableadmin/v2"
	^
google/config.go:24:2: other declaration of v2 (typecheck)
	"google.golang.org/api/bigquery/v2"
	^
google/config.go:27:2: `v1` redeclared in this block (typecheck)
	"google.golang.org/api/cloudbuild/v1"
	^
google/config.go:26:2: other declaration of v1 (typecheck)
	"google.golang.org/api/cloudbilling/v1"
	^
google/config.go:28:2: `v1` redeclared in this block (typecheck)
	"google.golang.org/api/cloudfunctions/v1"
	^
google/config.go:29:2: `v1` redeclared in this block (typecheck)
	"google.golang.org/api/cloudidentity/v1"
	^
google/config.go:30:2: `v1` redeclared in this block (typecheck)
	"google.golang.org/api/cloudiot/v1"
	^
google/config.go:31:2: `v1` redeclared in this block (typecheck)
	"google.golang.org/api/cloudkms/v1"
	^

Is this a blocking issue?

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician requested a review from melinath May 9, 2022 23:40
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1121 insertions(+), 43 deletions(-))
Terraform Beta: Diff ( 8 files changed, 183 insertions(+), 57 deletions(-))
TF Validator: Diff ( 4 files changed, 217 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 6 files changed, 108 insertions(+), 8 deletions(-))

@gutschenritter gutschenritter marked this pull request as ready for review May 10, 2022 00:10
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2014
Passed tests 1780
Skipped tests: 231
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccBigqueryConnectionConnection_bigqueryConnectionCloudResourceExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudResourceExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@melinath
Copy link
Member

linting is passing in CI/CD - probably a go version mismatch (or different linter version) on your local machine. Nothing to worry about. The remaining test failure is also unrelated.

@melinath
Copy link
Member

since this is making a new resource GA I'm doing an explicit run of the new tests in GA as well: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/288989 (the default test run is in beta)

@gutschenritter
Copy link
Contributor Author

since this is making a new resource GA I'm doing an explicit run of the new tests in GA as well: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/288989 (the default test run is in beta)

Did these tests pass? (I can't view the link) I ran them locally & they succeeded.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bigquery connection of type CLOUD_RESOURCE
3 participants