Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the Magician fail more clearly if one or both generator steps fail #11978

Open
rileykarson opened this issue Jun 28, 2022 · 0 comments
Open

Have the Magician fail more clearly if one or both generator steps fail #11978

rileykarson opened this issue Jun 28, 2022 · 0 comments
Labels
magician Issues and features related to our bespoke CI service/terraform size/s technical-debt
Milestone
Near-Term Goals

Comments

@rileykarson
Copy link
Collaborator

See GoogleCloudPlatform/magic-modules#6179, where generation keeps going after tpgtools fails, and we won't produce a working provider. We should return a clear failure message, and point the author (for maintainers and Googlers) or reviewer (for external contributions) towards the Cloud Build log for details.
@rileykarson rileykarson added technical-debt mmv1-generator Provider-wide changes to resource templates or other generator changes labels Jun 28, 2022
@rileykarson rileykarson added this to the Near-Term Goals milestone Jul 11, 2022
@rileykarson rileykarson added magician Issues and features related to our bespoke CI and removed mmv1-generator Provider-wide changes to resource templates or other generator changes labels Mar 28, 2024
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Oct 14, 2024
@modular-magician
Send empty GKE objects explicitly (hashicorp#11978)
a08f11b 
[upstream:285e7be5c17f8a3edddf507854155b8ef3dabc02]

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Oct 14, 2024
@modular-magician
Send empty GKE objects explicitly (#11978) (#19842)
a56e3e7 
[upstream:285e7be5c17f8a3edddf507854155b8ef3dabc02]

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
magician Issues and features related to our bespoke CI service/terraform size/s technical-debt
Projects
None yet
Milestone
Near-Term Goals
Development

No branches or pull requests
2 participants
@melinath @rileykarson