Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cgroupMode option under linux_node_config for GKE nodes #15656

Closed
arpitairan opened this issue Aug 29, 2023 · 2 comments · Fixed by GoogleCloudPlatform/magic-modules#8997, hashicorp/terraform-provider-google-beta#6435 or #16103

Comments

@arpitairan
Copy link

arpitairan commented Aug 29, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

GKE has made the use of cgroup v2 the default since GKE v1.26 and has added the Linux cgroup mode configuration options to allow customers to change from the default CGROUP_MODE_V2 to CGROUP_MODE_V1 to avoid issues like Node memory usage on cgroupv2 reported higher than cgroupv1.

The option to manage the cgroup mode configuration under LinuxNodeConfig seems to be missing from the Terraform Google Provider.

Please add the cgroup_mode option under linux_node_config similar to how Upstream support for Kubelet and Linux Node configurations in GKE was added.

New or Affected Resource(s)

  • google_container_cluster
  • google_container_node_pool

Potential Terraform Configuration

resource "google_container_cluster" "primary" {
  ...
  node_config {
     ...
    linux_node_config {
      sysctls {
        ...
      }
      cgroup_mode = string
    }
  }
}

References

b/299312482

@toVersus
Copy link
Contributor

I submitted the PR to add this feature. See GoogleCloudPlatform/magic-modules#8997.

Copy link

github-actions bot commented Nov 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.