feat(container_node_pool): support cgroup mode

[toVersus]

Fixes: hashicorp/terraform-provider-google#15656

This PR added support for setting cgroup version to the google_container_node_pool resource. This allows users to switch to use cgroup v2 for their existing node pools. See Linux cgroup mode configuration option and corresponding REST API doc.

Release Note Template for Downstream PRs (will be copied)

container: added `node_config.linux_node_config.cgroup_mode` field to `google_container_node_pool`

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 120 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 120 insertions(+), 21 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (248 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      cgroup_mode = # value needed
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        cgroup_mode = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3070
Passed tests 2770
Skipped tests: 299
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withCgroupMode

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withCgroupMode[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[melinath]

Reassigning review due to OOO.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 88 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 88 insertions(+), 21 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (246 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      cgroup_mode = # value needed
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        cgroup_mode = # value needed
      }
    }
  }
}

Resource: google_container_node_pool (54 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_node_pool" "primary" {
  node_config {
    linux_node_config {
      cgroup_mode = # value needed
    }
  }
}

[NickElliot]

Sorry I took so long to get to this review! Has been a busy week.

It looks like when you rebased you accidentally removed your "testAccContainerNodePool_withCgroupMode" case -- only the larger test function that calls that smaller one is in the file right now.

[modular-magician]

Tests analytics

Total tests: 2919
Passed tests 2630
Skipped tests: 289
Affected tests: 0

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[toVersus]

Sorry I took so long to get to this review! Has been a busy week.

No problem! Thanks for making the time.

It looks like when you rebased you accidentally removed your "testAccContainerNodePool_withCgroupMode" case -- only the larger test function that calls that smaller one is in the file right now.

My bad. Fixed!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 120 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 120 insertions(+), 21 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (246 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      cgroup_mode = # value needed
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        cgroup_mode = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3102
Passed tests 2782
Skipped tests: 313
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withCgroupMode|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDataSourceGoogleServiceAccountJwt|TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccContainerNodePool_withCgroupMode[Error message] [Debug log]
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

TestAccContainerNodePool_withCgroupMode is failing with a "Error: Cannot destroy cluster because deletion_protection is set to true. Set it to false to proceed with instance deletion.", and presumably needs to have that configured to be false.

[toVersus]

Thanks for the pointer! I think this change (#9013) is introducing the requirement to explicitly set deletion_protection = false on the google_container_cluster resource when deleting clusters in tests. Fixed.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 121 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 121 insertions(+), 21 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_cluster (246 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  node_config {
    linux_node_config {
      cgroup_mode = # value needed
    }
  }
  node_pool {
    node_config {
      linux_node_config {
        cgroup_mode = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 3113
Passed tests 2794
Skipped tests: 314
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withCgroupMode|TestAccContainerCluster_withAddons|TestAccContainerNodePool_withKubeletConfig|TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerNodePool_withCgroupMode[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerNodePool_withUpgradeSettings[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccContainerNodePool_withKubeletConfig[Error message] [Debug log]
TestAccDataprocClusterIamPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[NickElliot]

LGTM 🙂