-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deletion_protection to container cluster #9013
Add deletion_protection to container cluster #9013
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
88914ef
to
c5e5c8f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c5e5c8f
to
e06b8e5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c9fa7e1
to
ca2400b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 31 files changed, 938 insertions(+), 462 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withAddons|TestAccContainerNodePool_withSandboxConfig|TestAccDataSourceGoogleServiceAccountAccessToken_basic |
Rerun these tests in REPLAYING mode to catch issues
|
ca2400b
to
5a1bcaa
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change Detection FailedThe breaking change detector crashed during execution. This is usually due to the downstream provider(s) failing to compile. Please investigate or follow up with your reviewer. Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 33 files changed, 2576 insertions(+), 463 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 33 files changed, 2576 insertions(+), 463 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountIdToken_impersonation |
Rerun these tests in REPLAYING mode to catch issues
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - have you been able to manually confirm that the state upgrader works as expected?
Yes, I've started with a minimally configured cluster on 4.83, tried to upgrade with the state upgrader and got a diff. Upgraded with the state upgrader and there was no diff. |
887cf20
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
fixes hashicorp/terraform-provider-google#10168
upgrade guide: #9087
Creates
deletion_protection
which is enabled by default.Commits are separated out for review convenience (except for test fixes)
Essentially used the same approach for
deletion_protection
and the state upgrader as in https://github.com/GoogleCloudPlatform/magic-modules/pull/3450/filesRelease Note Template for Downstream PRs (will be copied)