Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletion_protection to container cluster #16013

Conversation

modular-magician
Copy link
Collaborator

fixes #10168
upgrade guide: GoogleCloudPlatform/magic-modules#9087

Creates deletion_protection which is enabled by default.
Commits are separated out for review convenience (except for test fixes)

Essentially used the same approach for deletion_protection and the state upgrader as in https://github.com/GoogleCloudPlatform/magic-modules/pull/3450/files

Release Note Template for Downstream PRs (will be copied)

container: `google_container_cluster` now has `deletion_protection` enabled to `true` by default. When enabled, this field prevents Terraform from deleting the resource.

Derived from GoogleCloudPlatform/magic-modules#9013

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 24afffd into hashicorp:FEATURE-BRANCH-major-release-5.0.0 Sep 26, 2023
3 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant