Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container cluster upgrade guide pt 3 #9087

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Container cluster upgrade guide pt 3 #9087

merged 3 commits into from
Sep 28, 2023

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 26, 2023 •
edited
Loading

upgrade guide for #9013

Release Note Template for Downstream PRs (will be copied)

@c2thorn c2thorn mentioned this pull request Sep 26, 2023
Merged
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 36 insertions(+))
Terraform Beta: Diff ( 1 file changed, 36 insertions(+))

melinath
melinath approved these changes Sep 26, 2023
View reviewed changes
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated Show resolved Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown Outdated
**`deletion_protection` does NOT prevent deletion outside of Terraform.**
To destroy a `google_container_cluster`, this field must be explicitly set to `false`.

### `networking_mode` defaults to `VPC_NATIVE` for newly created clusters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this section a bit hard to parse but I'm not sure how to improve it; the change looks complex.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this section for now, as it has not been approved yet.

This was referenced Sep 26, 2023
Merged
Merged
Merged
Merged
c2thorn and others added 2 commits September 26, 2023 17:25
@c2thorn
Update version_5_upgrade.html.markdown
0df473e
@c2thorn @melinath
Update mmv1/third_party/terraform/website/docs/guides/version_5_upgra…
4482f19 
…de.html.markdown

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 7 insertions(+))
Terraform Beta: Diff ( 1 file changed, 7 insertions(+))

@c2thorn c2thorn merged commit fd6b70a into GoogleCloudPlatform:main Sep 28, 2023
13 checks passed
This was referenced Sep 28, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c2thorn @modular-magician @melinath