Add deletion_protection to container cluster #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
shuyama1
and removed request for
a team
modular-magician
merged commit df57320
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes hashicorp/terraform-provider-google#10168
upgrade guide: GoogleCloudPlatform/magic-modules#9087
Creates
deletion_protectionwhich is enabled by default.Commits are separated out for review convenience (except for test fixes)
Essentially used the same approach for
deletion_protectionand the state upgrader as in https://github.com/GoogleCloudPlatform/magic-modules/pull/3450/filesRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9013