-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looker-instance: add possibility to add the custom-domain to a looker instance (optional argument) #17193
Looker-instance: add possibility to add the custom-domain to a looker instance (optional argument) #17193
Comments
Confirmed this appears to be configurable through the API: https://cloud.google.com/looker/docs/reference/rest/v1/projects.locations.instances#CustomDomain |
A simple yet very valuable enhancement to this resource 👍🏼 . Thanks for taking the time to raise this issue @WimDiepgrond. |
Great addition indeed. I can pick this one up and create a PR for it :) |
Awesome, I'll happily review your contribution - see Getting Started on Magic Modules for some helpful resources. |
Hope it will be available soon !! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Description
When deploying a looker instance with terraform there is no possibility to add a custom domain to it.
Now we have to add the custom domain afterwards with the GCLOUD CLI or through the portal (not wanted because of full automation needed).
Since the GCLOUD CLI already supports the argument (--custom-domain) with the create and update command it would be nice to also have it in the TF resource.
New or Affected Resource(s)
Potential Terraform Configuration
custom_domain - (Optional) Custom domain name that will be used for the Looker Instance.
b/324218901
The text was updated successfully, but these errors were encountered: