Looker-instance: add possibility to add the custom-domain to a looker instance (optional argument)

[WimDiepgrond]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

When deploying a looker instance with terraform there is no possibility to add a custom domain to it.
Now we have to add the custom domain afterwards with the GCLOUD CLI or through the portal (not wanted because of full automation needed).
Since the GCLOUD CLI already supports the argument (--custom-domain) with the create and update command it would be nice to also have it in the TF resource.

New or Affected Resource(s)

• google_looker_instance (affected)

Potential Terraform Configuration

custom_domain - (Optional) Custom domain name that will be used for the Looker Instance.

resource "google_looker_instance" "looker-instance" {
  name              = "my-instance"
  platform_edition  = "LOOKER_CORE_STANDARD"
  region            = "us-central1"
  **custom_domain = "my.testdomain.com"**
  oauth_config {
    client_id = "my-client-id"
    client_secret = "my-client-secret"
  }
  .....
}

b/324218901

[roaks3]

Confirmed this appears to be configurable through the API: https://cloud.google.com/looker/docs/reference/rest/v1/projects.locations.instances#CustomDomain

[bschaatsbergen]

A simple yet very valuable enhancement to this resource 👍🏼 . Thanks for taking the time to raise this issue @WimDiepgrond.

[nkhasuntsev]

Great addition indeed. I can pick this one up and create a PR for it :)

[bschaatsbergen]

Great addition indeed. I can pick this one up and create a PR for it :)

Awesome, I'll happily review your contribution - see Getting Started on Magic Modules for some helpful resources.

[arnoldharteveld]

Hope it will be available soon !!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.