Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom domain configuration for Looker #17301

Conversation

modular-magician
Copy link
Collaborator

Fixes: #17193

Release Note Template for Downstream PRs (will be copied)

looker: added `custom_domain` field to `google_looker_instance ` resource

Derived from GoogleCloudPlatform/magic-modules#9936

* Add custom domain configuration for Looker

* Add test case

* Fix test

* Add small change in test to include domain

* Simplify domain state output

[upstream:04ddc21dd5f7cb400b14a5746042c6d0dfeea889]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 32c5e3c into hashicorp:main Feb 16, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looker-instance: add possibility to add the custom-domain to a looker instance (optional argument)
1 participant