Add support for scheduled snapshots for persistent disk

[Chupaka]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Scheduled snapshots feature is promoted to beta now, so it worth adding to google-beta provider :)
https://cloud.google.com/compute/docs/disks/scheduled-snapshots

[emilymye]

For reference, this would entail adding resource policies as a resource: https://cloud.google.com/compute/docs/reference/rest/beta/resourcePolicies/

[Lirt]

Hey,

I've encountered some permission problems with the scheduled snapshot resource policy. I am not sure if this is a bug in provider, but maybe somebody else bumped into this?

1. Created resource policy:

resource "google_compute_resource_policy" "XYZ-snapshot-schedule" {
  name        = "XYZ-snapshot-schedule"
  provider    = "google-beta"
  project     = "project1"
  region      = "us-central1"

  snapshot_schedule_policy {
    schedule {
      daily_schedule {
        days_in_cycle = 1
        start_time    = "02:00"
      }
    }
    retention_policy {
      max_retention_days    = 7
      on_source_disk_delete = "APPLY_RETENTION_POLICY"
    }
    snapshot_properties {
      labels = {
        app      = "XYZ"
      }
    }
  }
}

2. Attached it manually to disk.
3. terraform apply worked fine, but now when I hit terraform plan again I have this error:

Error: Error reading ComputeResourcePolicy "XYZ-snapshot-schedule": googleapi: 
Error 403: Required 'compute.resourcePolicies.get' permission for 
'projects/<PROJECT_NAME>/regions/us-central1/resourcePolicies/<XYZ>-snapshot-schedule',
forbidden.

4. Terraform user has these rights - Compute Viewer, Project Viewer, Role Viewer, Service Account User, Storage Admin

Compute Viewer should be enough for permission compute.resourcePolicies.get according to https://cloud.google.com/iam/docs/understanding-roles.

[tysen]

Hi @Lirt, I attempted to repro this using admin credentials and terraform plan did not fail in the way you observed. Is it possible for you to try with more permissions?

[Lirt]

I solved it, issue was I didn't have specified google-beta provider explicitly. Anyway, thank you for reproducing @tysen.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!