Add resource_policy resource to compute

[tysen]

Fixes hashicorp/terraform-provider-google#3062

---

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 3e7a15e99f64db235bbafc16a50a73bcddcb468b.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#784

[123BLiN]

@tysen
Not sure if this is right place to comment, sorry if not.

I think I have an issue with this build, it forces new resource every time due to the start_time
Here is terraform apply:

      snapshot_schedule_policy.#:                                              "1" => "1"
      snapshot_schedule_policy.0.retention_policy.#:                           "1" => "1"
      snapshot_schedule_policy.0.retention_policy.0.max_retention_days:        "7" => "7"
      snapshot_schedule_policy.0.retention_policy.0.on_source_disk_delete:     "KEEP_AUTO_SNAPSHOTS" => "KEEP_AUTO_SNAPSHOTS"
      snapshot_schedule_policy.0.schedule.#:                                   "1" => "1"
      snapshot_schedule_policy.0.schedule.0.daily_schedule.#:                  "1" => "1"
      snapshot_schedule_policy.0.schedule.0.daily_schedule.0.days_in_cycle:    "1" => "1"
      snapshot_schedule_policy.0.schedule.0.daily_schedule.0.start_time:       "05:00" => "5:00" (forces new resource)
      snapshot_schedule_policy.0.snapshot_properties.#:                        "1" => "1"
      snapshot_schedule_policy.0.snapshot_properties.0.labels.%:               "2" => "2"
      snapshot_schedule_policy.0.snapshot_properties.0.labels.retention:       "7_days" => "7_days"
      snapshot_schedule_policy.0.snapshot_properties.0.labels.snapshot_policy: "default-policy" => "default-policy"

main.tf:

provider "google-beta-resource-policy" {
  version = "~> 0.0.1"
  region  = "us-central1"
  project = "my-project"
}

resource "google_compute_resource_policy" "default" {
  provider = "google-beta-resource-policy"
  name     = "default-policy"
  region   = "us-central1"

  snapshot_schedule_policy {
    schedule {
      daily_schedule {
        start_time    = "5:00"
        days_in_cycle = 1
      }
    }

    retention_policy {
      max_retention_days    = 7
      on_source_disk_delete = "KEEP_AUTO_SNAPSHOTS"
    }

    snapshot_properties {
      labels = {
        snapshot_policy = "default-policy"
        retention       = "7_days"
      }
    }
  }
}

also it want to update region:

  ~ update in-place

Terraform will perform the following actions:

  ~ google_compute_resource_policy.default
      region:                                                                  "https://www.googleapis.com/compute/v1/projects/my-project/regions/us-central1" => "us-central1"

terraform version

Terraform v0.11.14
+ provider.google-beta-resource-policy v0.0.1

Your version of Terraform is out of date! The latest version
is 0.12.0. You can update by downloading from www.terraform.io/downloads.html

[tysen]

@123BLiN Thanks for the feedback. For the issue with start_time, the docs state that they must be specified in HH:MM format. That should resolve your issue but I'll see if it makes sense to add some validation for that field.

Thanks for the call out on the region field - I'll fix that.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 57a0f7a.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 54e9fad.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[emilymye]

Also just noticed, the website listing needs to be updated manually (see third_party/terraform/website-compiled/google.erb under Compute Resources).

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2a1ddeb.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#3768

[emilymye]

Almost done! One last comment, but otherwise LGTM. Thanks for dealing with incremental reviews

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 857a434.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 857a434.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.