Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Test Sweepers #3288

Closed
rileykarson opened this issue Mar 20, 2019 · 3 comments
Closed

Improve Test Sweepers #3288

rileykarson opened this issue Mar 20, 2019 · 3 comments
Assignees
@c2thorn
Labels
size/xl technical-debt
Milestone
Near-Term Goals

Comments

@rileykarson
Copy link
Collaborator

Sweepers don't cover a lot of newer products, and we have a lot of leftover ones in existing ones like networking. We should improve them so we can be more confident in our tests.
@c2thorn c2thorn self-assigned this Dec 9, 2019
@paddycarver paddycarver added this to the Near-Term Goals milestone Dec 11, 2019
@danawillow
Copy link
Contributor

Putting this as XL since it touches a bunch of resources. @c2thorn, if you want to divide this into smaller issues once you've done the first one and have a better sense of the scope, feel free!

@c2thorn c2thorn mentioned this issue Dec 16, 2019
Closed
This was referenced Jan 3, 2020
Closed
Closed
@danawillow danawillow reopened this Feb 10, 2020
@rileykarson
Copy link
Collaborator Author

Keeping open for @c2thorn to split this into a few smaller issues

This was referenced Feb 10, 2020
Closed
Closed
@c2thorn c2thorn closed this as completed Feb 10, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Mar 24, 2020
@modular-magician
GA google_container_cluster maintenance policy recurring window (hash…
0ed34f7 
…icorp#3288)

* GA release_channel and maintenance window recurring policy

* Un GA release_channel, it is not ga

* Move validate to validation.go, GA diff suppress too

* Ga test too

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Mar 24, 2020
@modular-magician
GA google_container_cluster maintenance policy recurring window (#3288)…
261cd16 
… (#5962)

* GA release_channel and maintenance window recurring policy

* Un GA release_channel, it is not ga

* Move validate to validation.go, GA diff suppress too

* Ga test too

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@c2thorn c2thorn

Labels
size/xl technical-debt
Projects
None yet
Milestone
Near-Term Goals
Development

No branches or pull requests
4 participants
@paddycarver @danawillow @rileykarson @c2thorn