Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_container_cluster fields recreate the cluster unnecesarily #474

Closed
paddycarver opened this issue Sep 27, 2017 · 5 comments
Closed
Assignees

Comments

@paddycarver
Copy link
Contributor

paddycarver commented Sep 27, 2017

It should be possible to update, e.g., the node_pool field on google_container_cluster without tearing down the cluster and recreating it. However, at the moment, Terraform requires the cluster to be destroyed and recreated in order to make changes to many of the fields.

@paddycarver
Copy link
Contributor Author

When google_container_cluster was created, the API didn't support updating most (or all, I forget) of its fields. Now the API has progressed, but the resource hasn't been updated to support the new functionality. I think for a lot of this, it's just a matter of updating the resource to do the update API call and marking the fields as ForceNew: false.

@davidquarles
Copy link
Contributor

Realistically, this behavior (specifically: when mutating google_container_cluster.node_pool) is the main deal-breaker for us (with IP Aliases as a close second), and I'd really like to use terraform to keep our tooling consistent with cluster provisioning on the AWS side. If you'd like help, I have bandwidth to do so this week.

@danawillow
Copy link
Contributor

@davidquarles happy to have help! Just let me know which ones you're planning on doing so I don't accidentally do the same ones.

@danawillow
Copy link
Contributor

Closing this in favor of more granular issues per field that needs to be updatable (I think most are now anyway)

luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants