Adding support for "Private service access" for Cloud MemoryStore Redis (for Shared VPC setups)

[iiro]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

At the moment, the google_redis_instance resource does not support creating the Redis

But, as this feature was just announced, this should now be possible:

https://cloud.google.com/memorystore/docs/redis/release-notes#February_27_2020
https://cloud.google.com/memorystore/docs/redis/networking
https://cloud.google.com/memorystore/docs/redis/creating-managing-instances#creating_a_redis_instance_with_a_shared_vpc_network_in_a_service_project

New or Affected Resource(s)

• google_redis_instance

Potential Terraform Configuration

# No actual idea, but maybe aligning on how things happen with Cloud SQL (if applicable?): https://www.terraform.io/docs/providers/google/r/sql_database_instance.html

References

[Gatsby-Lee]

@danawillow Thank you for working on this :)

[Gatsby-Lee]

@danawillow Do you have any timeline for this?

[danawillow]

This is in our Goals milestone, which means it's something we'd like to do but don't have a timeline on. You can see our full list of sprints and milestones at https://github.com/terraform-providers/terraform-provider-google/milestones, and we move things around depending on demand. We always happily accept PRs, which is the easiest way for you to control the timeline around features. Otherwise, we use a combination of thumbs ups and customer interest (reported internally to us via TAMs, CEs, and similar roles at Google/HashiCorp) to determine which things get moved from Goals -> Near Term, and from there into a sprint.

[iiro]

@danawillow since I've created the issue, I've received some mixed messages from my peers at Google. They said things should already work without any additions, which sounded like the issue actually would not be valid. @danawillow were they right, or is there pending work to be done to the provider on this?

[iiro]

And @danawillow thank you for the update on this :) I need to ping both peers at Google and Hashicorp if we can affect this to get more action ;) Unfortunately we're very blocked by this, cannot go live with a project at all... :/ I'd like to try to help with a PR here, but unfortunately there are legal obstacles on the way.

[Gatsby-Lee]

@iiro BTW, this is not only related to Shared VPC. connection-mode ( direct peering / private services access ) argument is not supported.

[danawillow]

Well, not sure whether it was you or a coincidence but this just popped up on our internal tracker :)

@Gatsby-Lee yup, the only thing missing from our end right now from what I can tell is the connect-mode argument.

[Gatsby-Lee]

@danawillow Nice!!. it's PR2 now. 👍

[syl20bnr]

Thank you for working on this, this is great to have this limitation being addressed.

Will this be in the provider v2 or in v3 only ?

[danawillow]

We try to make our release numbers monotonically increasing as best as possible, so it'll be in 3.X. 2.X releases are only being done in emergencies (such as an API changing out from underneath us that makes the provider unusable)

[Gatsby-Lee]

Thank you.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!