Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memorystore Redis connectMode support #3246

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

drebes
Copy link
Member

@drebes drebes commented Mar 11, 2020

Fixes hashicorp/terraform-provider-google#5792

Release Note Template for Downstream PRs (will be copied)

redis: added `connect_mode` field to `google_redis_instance` resource

@drebes drebes requested a review from danawillow March 11, 2020 22:54
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 142 insertions(+))
Terraform Beta: Diff ( 3 files changed, 142 insertions(+))
Ansible: Diff ( 2 files changed, 22 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

products/redis/api.yaml Outdated Show resolved Hide resolved
products/redis/terraform.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 143 insertions(+))
Terraform Beta: Diff ( 3 files changed, 143 insertions(+))
Ansible: Diff ( 2 files changed, 24 insertions(+))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))
Inspec: Diff ( 4 files changed, 7 insertions(+))

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always for your contribution, @drebes :)

@pantelis-karamolegkos
Copy link

pantelis-karamolegkos commented Jun 15, 2020

I am trying to create a redis memorystore instance.
Using Terraform v0.11.14 and provider "google-beta" {}.

I am getting this error:

Error: google_redis_instance.ats_redis_memorystore: : invalid or unknown key: connect_mode

Does this make sense?

@drebes
Copy link
Member Author

drebes commented Jun 15, 2020

You need to be using at least version 3.14.o of the google-beta provider:

https://github.com/terraform-providers/terraform-provider-google-beta/blob/master/CHANGELOG.md#3140-march-23-2020

@pantelis-karamolegkos
Copy link

Yes but since I am setting provider "google-beta" {} this does not impose any restriction at all; am I wrong on this?

@pantelis-karamolegkos
Copy link

Or is the problem caused by the old TF version I am using? (0.11.14) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for "Private service access" for Cloud MemoryStore Redis (for Shared VPC setups)
5 participants