Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user project overrides for Cloud Functions #5885

Open
danawillow opened this issue Mar 11, 2020 · 0 comments
Open

Add user project overrides for Cloud Functions #5885

danawillow opened this issue Mar 11, 2020 · 0 comments

Comments

@danawillow
Copy link
Contributor

danawillow commented Mar 11, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

In #5388, we learned that the Cloud Functions API is no longer accepting gcloud credentials for waiting on Operations, which leads to a not-so-great UX for creating or modifying those functions from Terraform (the function ends up getting created correctly, but polling fails, so future TF runs won't realize it was created correctly).

Users can work around this for generated resource by using User Project Overrides, but we don't have that support yet across the board for handwritten resources; it has to be added one by one. We can do this by adding a https://godoc.org/google.golang.org/api/cloudfunctions/v1#OperationsGetCall.Header to the call setting X-Goog-User-Project like we do in sendRequestWithTimeout (and a few other places). Just needs some plumbing to pass along the project through and to check whether the user is using user project overrides.

New or Affected Resource(s)

  • google_cloudfunctions_function

References

  • b/148479480
  • b/274819432
@ghost ghost added the enhancement label Mar 11, 2020
@danawillow danawillow added this to the Goals milestone Mar 16, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Apr 6, 2022
hashicorp#5885)

* Add support for Airflow major version aliases

This covers the new aliases for Airflow major version ('airflow-1',
'airflow-2') in image version field, and updates to the related
documentation.

* Use image version aliases in Composer tests

Instead of finding the latest available image version for the given
Composer and Airflow major versions, the new image version aliases are
used to let Composer resolve them on the server side:
'composer-1-airflow-1', 'composer-1-airflow-2', 'composer-2-airflow-2'.

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Apr 6, 2022
#5885) (#11422)

* Add support for Airflow major version aliases

This covers the new aliases for Airflow major version ('airflow-1',
'airflow-2') in image version field, and updates to the related
documentation.

* Use image version aliases in Composer tests

Instead of finding the latest available image version for the given
Composer and Airflow major versions, the new image version aliases are
used to let Composer resolve them on the server side:
'composer-1-airflow-1', 'composer-1-airflow-2', 'composer-2-airflow-2'.

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants