Allow setting the storage location for google_compute_image resource

[chrisob]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently, the google_compute_image resource doesn't allow setting the location of the image storage (storageLocations in the API).

The image location defaults to us, which is usually fine except when organizations have constraints/conditions in place to prevent using US-based storage 🙂

New or Affected Resource(s)

• google_compute_image

Potential Terraform Configuration

resource "google_compute_image" "rhcos-image" {
  name = "rhcos-image"
  raw_disk {
    source = "https://storage.googleapis.com/rhcos/rhcos/rhcos-44-81-202003062006-0-gcp-x86-64.tar.gz"
  }
  location = "eu"
}

References

b/221093509

[mjlshen]

Is there a way I can work on this? From my understanding, since this resource is autogenerated any PR I make would be rejected, is this true?

[rosmo]

@mjlshen The resource is autogenerated, but you can make the PR against the magic-modules repository.

In this case, adding something like this to mmv1/products/compute/api.yaml under Image objects properties should do the trick:

      - !ruby/object:Api::Type::Array
        name: 'storageLocations'
        description: |
          Cloud Storage bucket storage location of the image (regional or multi-regional).
        item_type: Api::Type::String

[melinath]

@mjlshen I'm assigning this to a contributor - if you're already working on a fix & nearly complete we can go with that instead.

[melinath]

ah @c2thorn already beat me to it.

[mjlshen]

I haven't gotten around to it yet, thanks!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.