Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide whether dataflow jobs (and other resource jobs) should be removed from state when they finish #7152

Open
danawillow opened this issue Aug 28, 2020 · 1 comment
Open

Decide whether dataflow jobs (and other resource jobs) should be removed from state when they finish #7152

danawillow opened this issue Aug 28, 2020 · 1 comment
Labels
breaking-change decision-needed enhancement size/l
Milestone
Backlog

Comments

@danawillow
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Right now they are, which allows people to terraform apply the job again after it finishes. My impression is that other job resources leave the resource around when they finish, which would require tainting it or changing a ForceNew field to trigger a re-run. I think some other GCP job resources might also not even run the job on create, but just stage it, with a different API call running it. It would be good to have some consistency.

New or Affected Resource(s)

  • google_*_job

References
@ghost ghost added the enhancement label Aug 28, 2020
@danawillow danawillow added this to the 4.0.0 milestone Aug 31, 2020
@danawillow
Copy link
Contributor Author

Calling it large/4.0.0 because requires some thinking on how to be consistent across resources

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Jan 24, 2023
@modular-magician
Adding in Point in time recovery for SQLServer (hashicorp#7152)
d945f1b 
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Jan 24, 2023
@modular-magician
Adding in Point in time recovery for SQLServer (#7152) (#13555)
d52c3c8 
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change decision-needed enhancement size/l
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@danawillow @rileykarson @c2thorn