Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts on storage bucket iam please #7283

Open
gtmtech opened this issue Sep 16, 2020 · 0 comments
Open

Timeouts on storage bucket iam please #7283

gtmtech opened this issue Sep 16, 2020 · 0 comments

Comments

@gtmtech
Copy link

gtmtech commented Sep 16, 2020

Affected Resource(s)

  • google_storage_bucket_iam

Can we have configurable timeouts on storage bucket iam please. It shouldn't block on waiting 30 minutes / 1 hour or whatever it is for a simple iam policy update, but should be more responsive. Suggest 2 minutes max as a default but at the very minimum allow overriding...

module.bootstrap.google_storage_bucket_iam_member.jenkins_rw_bucket_reader_uswest2[0]: Still creating... [30s elapsed]
module.bootstrap.google_storage_bucket_iam_member.jenkins_rw_bucket_reader_uswest2[0]: Still creating... [40s elapsed]
....
.... snip
....
module.bootstrap.google_storage_bucket_iam_member.jenkins_rw_bucket_reader_uswest2[0]: Still creating... [18m20s elapsed]
module.bootstrap.google_storage_bucket_iam_member.jenkins_rw_bucket_reader_uswest2[0]: Still creating... [18m30s elapsed]
module.bootstrap.google_storage_bucket_iam_member.jenkins_rw_bucket_reader_uswest2[0]: Still creating... [18m40s elapsed]

Perhaps this could be extended to all iam updates, but taking a look at the code it seems Timeouts are sometimes included sometimes not.

b/275617339

@nat-henderson nat-henderson added this to the Goals milestone Sep 21, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Feb 23, 2023
…ashicorp#7283)

* feat: Add support for deletion_policy on shared vpc service project

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>

* test: Add tests for deletion_policy on shared vpc service project

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>

* fix: reorder tests for better coverage

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>

* Update mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* fix: add comma in test

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>

* fix formatting

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>

---------

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Feb 23, 2023
…7283) (#13822)

* feat: Add support for deletion_policy on shared vpc service project



* test: Add tests for deletion_policy on shared vpc service project



* fix: reorder tests for better coverage



* Update mmv1/third_party/terraform/resources/resource_compute_shared_vpc_service_project.go.erb



* fix: add comma in test



* fix formatting



---------

Signed-off-by: NexusNull <p.wellershaus@googlemail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants