Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_dataproc_cluster_iam shows headers for google_pubsub_subscription_iam. #7670

Closed
bartcode opened this issue Oct 29, 2020 · 1 comment
Closed

google_dataproc_cluster_iam shows headers for google_pubsub_subscription_iam. #7670

bartcode opened this issue Oct 29, 2020 · 1 comment
Assignees
@bartcode
Labels
bug forward/linked service/dataproc service/pubsub

Comments

@bartcode
Copy link
Contributor

bartcode commented Oct 29, 2020 •
edited by modular-magician
Loading

Affected Resource(s)

  • google_dataproc_cluster_iam
  • google_pubsub_subscription_iam

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Description

On the documentation page of google_dataproc_cluster_iam, the headers are mentioning pubsub (e.g. google_pubsub_subscription_iam_policy). The examples are correct, it's just the headers that are wrong.

b/308569349
b/308569682
@ghost ghost added the bug label Oct 29, 2020
@bartcode bartcode mentioned this issue Oct 29, 2020
Closed
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Apr 13, 2023
@modular-magician
Update tests for Composer 1 & 2 with node_config, also Update docs fo…
56a062a 
…r Composer 2 (hashicorp#7670)

* Update decumentation. Composer2 also has tags as optional parameter.

CHG: Realistic oauth_scopes.

* FIX: wrong function.

* FIX: Disk size 2-> 20.

* CHG: Name to reflect broather sense of tests.

* FIX: composer version 1->2 in proper test. Rm: Unused function.

* CHG: Names remove _withTags. RM: Zone, max_pods, use_ip_aliases from Composer2.

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Apr 13, 2023
@modular-magician
Update tests for Composer 1 & 2 with node_config, also Update docs fo…
2445ffe 
…r Composer 2 (#7670) (#14315)

* Update decumentation. Composer2 also has tags as optional parameter.

CHG: Realistic oauth_scopes.

* FIX: wrong function.

* FIX: Disk size 2-> 20.

* CHG: Name to reflect broather sense of tests.

* FIX: composer version 1->2 in proper test. Rm: Unused function.

* CHG: Names remove _withTags. RM: Zone, max_pods, use_ip_aliases from Composer2.

Signed-off-by: Modular Magician <magic-modules@google.com>
@github-actions github-actions bot added service/dataproc forward/review In review; remove label to forward service/pubsub labels Aug 17, 2023
@edwardmedia edwardmedia removed the forward/review In review; remove label to forward label Oct 30, 2023
@cnauroth
Copy link

I believe this was resolved in #7672 . Can we please close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartcode bartcode

Labels
bug forward/linked service/dataproc service/pubsub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct headers: should refer to dataproc, not pubsub
4 participants
@cnauroth @bartcode @modular-magician @edwardmedia