Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: TestAccContainerNodePool_withGPU - permadiff (update in place) #9485

Closed
melinath opened this issue Jul 1, 2021 · 3 comments
Closed

Comments

@melinath
Copy link
Collaborator

melinath commented Jul 1, 2021

This is also failing on all PRs. This would be good to fix soon.

example failure: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaGoogleProject/194456?buildTab=tests&status=failed&expandedTest=-811545022082220983

This has been happening since June 10th. It looks like a permadiff caused by google_container_node_pool.node_config.kubelet_config.cpu_cfs_quota getting set to false by the API.

output:

provider_test.go:276: Step 1/2 error: After applying this test step, the plan was not empty.
              stdout:
              
              
              An execution plan has been generated and is shown below.
              Resource actions are indicated with the following symbols:
                ~ update in-place
              
              Terraform will perform the following actions:
              
                # google_container_node_pool.np_with_gpu will be updated in-place
                ~ resource "google_container_node_pool" "np_with_gpu" {
                      id                  = "projects/ci-test-project-188019/locations/us-central1-c/clusters/tf-test-cluster-mf7e69lfn2/nodePools/tf-test-np-7w668kfgvh"
                      name                = "tf-test-np-7w668kfgvh"
                      # (8 unchanged attributes hidden)
              
              
                    ~ node_config {
                        + tags              = []
                          # (12 unchanged attributes hidden)
              
                        - kubelet_config {
                            - cpu_cfs_quota = false -> null
                          }
              
                          # (1 unchanged block hidden)
                      }
              
                      # (2 unchanged blocks hidden)
                  }
@mitj04
Copy link

mitj04 commented Dec 1, 2022

Currently, it has a success rate of 100% in GA Cloud build and 94% in Beta build but passes in all the latest builds.

Google Cloud: https://ci-oss.hashicorp.engineering/project.html?projectId=GoogleCloud&testNameId=-811545022082220983&tab=testDetails

Google Cloud Beta: https://ci-oss.hashicorp.engineering/project.html?projectId=GoogleCloudBeta&testNameId=-811545022082220983&tab=testDetails

@melinath
Copy link
Collaborator Author

melinath commented Dec 1, 2022

+1 looks like we resolved this at some point. The beta failures are a different permadiff that seems like it was time-limited.

@melinath melinath closed this as completed Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants