Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked cpu_cfs_quota as Computed #4947

Closed
wants to merge 1 commit into from

Conversation

melinath
Copy link
Member

@melinath melinath commented Jul 2, 2021

Resolved hashicorp/terraform-provider-google#9485.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: resolved permadiff in node kubelet_configs (beta)

@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 4 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=194846

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerNodePool_withGPU Please fix these to complete your PR

@melinath
Copy link
Member Author

melinath commented Jul 2, 2021

This doesn't seem to fix the issue

@melinath melinath closed this Jul 2, 2021
@melinath melinath deleted the tpg-9485 branch July 2, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: TestAccContainerNodePool_withGPU - permadiff (update in place)
2 participants