Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Cloud Build Worker Pool to GA. #10617

Conversation

modular-magician
Copy link
Collaborator

Note: this includes some unusual changes in the DCL due to deviations between the beta and GA APIs. Hopefully that oddness should be completely hidden from Terraform - if you see something that looks weird let me know, it is probably a symptom of incomplete conversion between beta and GA and should be fixed.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_cloudbuild_worker_pool in GA.
cloudbuild: added display_name and annotations to google_cloudbuild_worker_pool for compatibility with new GA.

Derived from GoogleCloudPlatform/magic-modules#5356

* Move Cloud Build Worker Pool to GA.

Note: this includes some unusual changes due to deviations between the beta and GA APIs.

* upgrade dcl.

* finish removing version gate.

* Use new GA / Beta versions, neither of which is ACL'd.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 8e555e2 into hashicorp:master Nov 22, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant