-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow module output when configuring firewall #10668
base: main
Are you sure you want to change the base?
Allow module output when configuring firewall #10668
Conversation
@slevenick, if you don't mind reviewing this! One other thing to look into is |
Any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this seems to not quite work. If a user specifies source_ranges during creation and then removes it from their config, Terraform does not throw an error because it finds that source_ranges exists (due to the computed value being in state)
But, I think this is a better behavior than what currently exists, and I'm not really sure that we can handle this in a better way
Ah, I see the problem. I tested the scenario where no I am curious if we can do better, though... I'm new to the provider codebase so I'll take your steer on that. Also wondering if we should close out this PR in favor of GoogleCloudPlatform/magic-modules#5526. |
Floated as a possible fix for #10494, but very much a work in progress.