Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation polling now supports custom endpoints #10913

Conversation

modular-magician
Copy link
Collaborator

Tests: I ran make testacc TEST=./google TESTARGS='-run=TestAccRedis' and got the following output: https://gist.github.com/smithson-google/92d8957671e9459424a1e5452eddf538. Tl;dr it passed on most tests. It only failed on tests which tried to use an API that hadn't been activated. I also ran a separate test with TF_LOG=DEBUG to make sure that HTTP requests were being sent as expected and they were. I didn't try to do my own testing with a custom endpoint, if necessary I can do that tomorrow.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Fixed operation polling to support custom endpoints.

Derived from GoogleCloudPlatform/magic-modules#5610

* Operation polling now supports custom endpoints

* Operation polling now supports custom endpoints

* Operation polling now supports custom endpoints

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 09ad788 into hashicorp:master Jan 14, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant