Operation polling now supports custom endpoints #10913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: I ran
make testacc TEST=./google TESTARGS='-run=TestAccRedis'
and got the following output: https://gist.github.com/smithson-google/92d8957671e9459424a1e5452eddf538. Tl;dr it passed on most tests. It only failed on tests which tried to use an API that hadn't been activated. I also ran a separate test withTF_LOG=DEBUG
to make sure that HTTP requests were being sent as expected and they were. I didn't try to do my own testing with a custom endpoint, if necessary I can do that tomorrow.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5610