Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SecretManager integration support to GCF. #11062

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Add SecretManager integration support to GCF. #11062

merged 1 commit into from
Feb 8, 2022

Conversation

modular-magician
Copy link
Collaborator

Add SecretManager integration support to GCF.

#9946

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
gcf: Added SecretManager integration support to GCF.

Derived from GoogleCloudPlatform/magic-modules#5663

@modular-magician @binamov
Add SecretManager integration support to GCF. (hashicorp#5663)
c63728a 
* Add SecretManager integration support to GCF.

* bug fix

* Correcting field requirements.

* Using zips created as part of the test.

* bug fix.

* addressing review comments.

* project_id is computed, otherwise project number

* test computedness of project_id for secret_env_vars

* test computedness

* removes unused declaration

* updating doc for project number.

Co-authored-by: Bakh Inamov <292705+binamov@users.noreply.github.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e37233f into hashicorp:master Feb 8, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician