Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EdgeCacheOrigin resources to reflect current API #11277

Conversation

modular-magician
Copy link
Collaborator

The google_network_services_edge_cache_origin resource is stale
compared to the current GCP Network Services API. This commit updates
the resources to keep them in sync.

  • Add the missing FORBIDDEN retry condition

  • Properly read and write the timeout property, including the
    previously missing read_timeout field.

  • Update field documentation to represent the documentation of the
    resource’s REST API.

I tested my changes with:

$ make testacc TEST=./google TESTARGS='-run=TestAccNetworkServicesEdgeCacheOrigin'

This is part of hashicorp/terraform-provider-google/#10722.

Signed-off-by: Justin Mazzola Paluska justinmp@google.com

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

networkservices: updated EdgeCacheOrigin to retry_conditions to include `FORBIDDEN`
networkservices: updated EdgeCacheOrigin resource to read and write the `timeout` property, including a new `read_timeout` field.

Derived from GoogleCloudPlatform/magic-modules#5776

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 09cf1b6 into hashicorp:main Mar 15, 2022
@justin-mp justin-mp mentioned this pull request Apr 12, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant