Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic deny policy support #11446

Conversation

modular-magician
Copy link
Collaborator

This is a combination of org/project/folder IAM deny policy as they are handled by the same endpoint with different "parent" fields.

This API actually handles IAM principals much more sanely than IAM policies do. Email based principals (users, groups) are strictly validated by the API and rejected if case does not match. This alleviates much of the normalization problem we have seen with IAM policies in general.

Team wanted authoritative approach per rule, as multiple rules can be set per parent

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_iam_deny_policy

Derived from GoogleCloudPlatform/magic-modules#5854

* Add basic deny policy support

Add etag to update

Add folder test

* Fix format for SA principal

* IAM deny test is only beta

* Make deny policies in new projects to avoid conflicts

* Dates

* PR feedback

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit ed92560 into hashicorp:main Apr 7, 2022
@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant