Make "schema" on "google_bigquery_table" ForceNew. #1147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not certain that this change should be merged - it solves one problem but creates another one. It is useful because most changes to schema cannot be supported without ForceNew... but some changes can be. There's no way to know without sending the change to BigQuery first, and by the time we send the change and get back the not-updateable error, it's too late to request a delete/create. So we need to choose between two sub-par choices - getting errors during `apply` because schema changes aren't possible, or ForceNew being overapplied, including to some changes that shouldn't need it.
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not certain that this change should be merged - it solves one
problem but creates another one. It is useful because most
changes to schema cannot be supported without ForceNew... but
some changes can be. There's no way to know without sending
the change to BigQuery first, and by the time we send the change
and get back the not-updateable error, it's too late to request
a delete/create.
So we need to choose between two sub-par choices - getting errors
during
applybecause schema changes aren't possible, or ForceNewbeing overapplied, including to some changes that shouldn't need it.
If merged, fixes #1144.