Prevent leaking credentials to the console if malformed JSON is given #11599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the JSON credentials are unable to be properly parsed, the error message will output those very credentials _in plain text_ to the console. This is obviously a serious security concern for any CI systems running Terraform that may produce this error. There's really no reason to output the "this string is what we can't parse" in the error message. The `err` is sufficient enough. The user can inspect their own JSON credentials file. I'm sure this can be done a better way, maybe by outputting it to the debug logs; however, this is a quick and easy fix to remove the security concern from this issue immediately while a better solution can be found.
megan07
approved these changes
Apr 27, 2022
megan07
approved these changes
Apr 27, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the JSON credentials are unable to be properly parsed, the error
message will output those very credentials in plain text to the
console. This is obviously a serious security concern for any CI systems
running Terraform that may produce this error.
There's really no reason to output the "this string is what we can't
parse" in the error message. The
erris sufficient enough. The usercan inspect their own JSON credentials file.
I'm sure this can be done a better way, maybe by outputting it to the
debug logs; however, this is a quick and easy fix to remove the security
concern from this issue immediately while a better solution can be
found.
Closes #11598