Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data sources for tag_keys and tag_values #11753

Conversation

modular-magician
Copy link
Collaborator

This PR creates data sources for google_tags_tag_key and google_tags_tag_vaule resources, so that they can be looked up by parent and short_name and one can avoid opaque magic numbers in one's Terraform configuration using tags.

Part of #11367 - the end goal of that issue may not be addressed unless the GCP IAM Tags API changes; until then these resources will accomplish the same goal, albeit in a roundabout fashion.

I borrowed heavily from the google_active_folder data source when writing this code. Hopefully I didn't miss any copypasta.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
    • Note there were several lint errors unrelated to my new code.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_tags_tag_key`
`google_tags_tag_value`

Derived from GoogleCloudPlatform/magic-modules#6042

* Created branch tag-data-sources from main

* initial commit of data sources for IAM tags

* Tests for tags data sources

* Added documentation

* Making error messages better

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 81d8e28 into hashicorp:main May 24, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant