Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_build_logs to google_cloudbuild_trigger #11866

Conversation

modular-magician
Copy link
Collaborator

Add support for include_build_logs to the google_cloudbuild_trigger resource

Fixes #11762

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: Added `include_build_logs` to `google_cloudbuild_trigger`

Derived from GoogleCloudPlatform/magic-modules#6111

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit b5cd00f into hashicorp:main Jun 10, 2022
@tedder
Copy link

tedder commented Jun 21, 2022

Note that by default, using 4.26.0 (which has this feature), will cause a previously enabled "include build logs" to get reset to "no build logs". What I mean is this:

  1. Have two builds, build_trigger_a, build_trigger_b.
  2. In the web UI for the trigger, check "Send build logs to GitHub" on build_trigger_a. Leave build_trigger_b unchecked.
  3. terraform plan

The following will appear on the checked trigger only, which is build_trigger_a. There's no drift on build_trigger_b.

  # google_cloudbuild_trigger.build_trigger_a will be updated in-place
  ~ resource "google_cloudbuild_trigger" "build_trigger_a" {
        id                 = "projects/myproject/triggers/build_trigger_a"
      - include_build_logs = "INCLUDE_BUILD_LOGS_WITH_STATUS" -> null
        name               = "build_trigger_a"
        tags               = []
        # (8 unchanged attributes hidden)

After running, the "Send build logs to GitHub" box becomes unchecked.

Not sure if it's a behavior worth worrying about.

This is a closed issue but I'm putting here because I suspect this is where any discussion would originate about it since it's linked in the changelog.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add includeBuildLogs to Cloud Build Trigger resource
2 participants