Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add certificate map entries #12127

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Add certificate map entries #12127

merged 1 commit into from
Jul 19, 2022

Conversation

modular-magician
Copy link
Collaborator

Add a certificate map entry resource. Related to issue GoogleCloudPlatform/magic-modules#5991

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

 `google_certificate_map_entry`

 `google_certificate_map`

Derived from GoogleCloudPlatform/magic-modules#6203

@modular-magician @SarahFrench
Add certificate map entries (hashicorp#6203)
bf9486c 
* Add CertificateMap resource

* Fix how fields made mutually exclusive

* Remove use of exactly_one_of

This wouldn't work as it cannot track indices.
Usually it's used with a list that's got max of 1 element

* added a certificate-map-resource

* fixed issues for certificate map entry rescource

* few modifications for comments and item type

* modify yaml files to include cert_name

* change ruby version

* corrected resource attributes

* change ruby version

* updated urls and objects

* updated my-map-entry to map

* fixing url errors

* fix errors

* Remove comments and update description of resource attribute

* remove extra line from managed_ssl_certificate_recreation file

* add comments to managed_ssl_certificate_recreation

Co-authored-by: Sarah French <sarah.french@hashicorp.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit fe20f17 into hashicorp:main Jul 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician