Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support location in google_cloudbuild_trigger. #12450

Conversation

modular-magician
Copy link
Collaborator

Summary of changes:

  • Add a url-only location parameter that defaults to "global"
  • The base paths have been updated to include locations/{{location}}/.
  • A schema migration inserts location="global" for already existing resources. https://www.terraform.io/plugin/sdkv2/resources/state-migration
  • To keep backwards compatibility in resource id, the post_create and post_import overrides change the resource id to projects/x/triggers/y instead of projects/x/locations/global/triggers/y for global triggers.
  • A pre_read override is necessary to continue supporting projects/x/triggers/y as import formats.
  • The schemaVersion field has been moved from resource_definition override to terraform.yaml. It has been increased to 2 to force migration for existing resources.
  • The migration from V0 to V1 is noop. Migration from V1 to V2 adds location="global".
  • Small fix to resource.erb template to properly handle generation of resources with more than 2 versions.
  • A handwritten test verifies that a resource can be created with an old version and then updated with the current version of the provider.

Fixes #11624

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added `location` field to `google_cloudbuild_trigger` resource

Derived from GoogleCloudPlatform/magic-modules#6440

Co-authored-by: Shuya Ma <87669292+shuyama1@users.noreply.github.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 308b17d into hashicorp:main Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support location parameter in google_cloudbuild_trigger
1 participant