Stop reading data_disk_type value from API response into state of google_notebooks_instance resource #12493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8485
That issue linked above describes a permadiff/permadelete situation where:
data_disk_type
data_disk_type
value, so it is set to""
in stateForceNew
fieldThis PR stops the
data_disk_type
value being read from the API to overwrite state.This matches how the boot disk arguments are handled:
https://github.com/GoogleCloudPlatform/magic-modules/blob/ea34ac204ae9216682497593ad5e383a16585ff3/mmv1/products/notebooks/terraform.yaml#L70-L73
List
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).N/ATestAccNotebooksInstance_
passRelease Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#6512