Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subordinate CA data sources in all states #12511

Conversation

modular-magician
Copy link
Collaborator

Resolves #12432

Currently, attempting to use a google_privateca_certificate_authority for a SUBORDINATE CA in any state other than AWAITING_USER_ACTIVATION is impossible, because the Google API can only fetch the CSR in that state (reference). This prevents some really common use cases, like pulling an existing subordinate CA to issue leaf certs.

With this change, pulling a subordinate CA in any state other than AWAITING_USER_ACTIVATION will result in pem_csr simply being unset. If the subordinate CA is in AWAITING_USER_ACTIVATION and the CSR fetch fails, an error will still be thrown as expected.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

privateca: fixed an issue that blocked subordinate CA data sources when `state` was not `AWAITING_USER_ACTIVATION`

Derived from GoogleCloudPlatform/magic-modules#6496

Co-authored-by: J. Cameron McDonald <cmcdonald@appdat.jsc.nasa.gov>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit cc1314c into hashicorp:main Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant