Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for errors in google_project datasource Read results #13358

Conversation

modular-magician
Copy link
Collaborator

Part of #12873, may address the issues encountered in #10587

We handle 403s in google_project with an error, which is not entirely correct to do. It's google_project so it's probably fine- if any resource acts weird on not founds, it's that one! However, there are a few cases where we do clear the resource out in the resource's read func:

  • If the API returns a 404. This is very unlikely to happen. That would imply a user has permissions on a project but it doesn't exist. Because projects are namespaced globally, they have to exist to have permissions attached, and if they don't exist, nobody has permissions, and they'll always 403. Maybe I'm missing a case.
  • If a project is not in the ACTIVE state. The only other valid state these days is DELETE_REQUESTED. For the project resource, clearing it from state is reasonabl. For the datasource, however, silently dropping it is not what we want to happen-that can inadvertently cause interpolations or references to see null or empty instead of a valid value, and recreate resources. Instead, returning an error is appropriate. (The blast radius is smaller than you may think- since projects are sticky in state, a resource seeing data.google_project.foobar.project_id as "" will actually just keep using the project in state. That's a mechanic to resolve another time w/ Use CustomizeDiff to infer the provider default values #11339)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

resourcemanager: fixed the `google_project` datasource silently returning empty results when the project was not found or not in the ACTIVE state. Now, an error will be surfaced instead.

Derived from GoogleCloudPlatform/magic-modules#7036

…rp#7036)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f5c58e5 into hashicorp:main Dec 28, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant