Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attached clusters #13374

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Attached clusters #13374

merged 1 commit into from
Jan 3, 2023

Conversation

modular-magician
Copy link
Collaborator

  • Added new resource for attached clusters google_container_attached_cluster
  • Added new datasource for retrieving valid attached cluster platform versions google_container_attached_versions
  • Added new datasource for retrieving a manifest to apply to the user cluster for boot-strapping google_container_attached_install_manifest

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_container_attached_cluster`

Derived from GoogleCloudPlatform/magic-modules#6858

@modular-magician
Attached clusters (hashicorp#6858)
c845f0e 
* Add support for google_container_attached clusters resource.

- Add support for CRUD operations to attached clusters.
- Add support for data source to retrieve valid attached cluster
  platform versions.
- Add support for data source to pull a manifest for deploying the
  install agent to a cluster before attaching.

* Split attached cluster data sources into a separate PR

* Address review comments.

- Add update test
- Proper handling of update mask for updates
- Changed logging_config handling to explicitly send an empty object if
  missing
- Misc cleanup

* Address more review comments.

- Fix update test formatting
- Prevent destroying containerattached resource during update test
- Remove auto-format for fleet project and validate format instead
- Fix error field structure

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 54daef4 into hashicorp:main Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician