Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHA and etag to AndroidApp and update package_name #13444

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Add SHA and etag to AndroidApp and update package_name #13444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changelog/7066.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
```release-note:enhancement
android_app: Added general fields `sha1_hashes`, `sha256_hashes` and `etag` to `google_firebase_android_app`.
```
```release-note:bug
android_app: Modify the `package_name` field suffix to always start with a letter in `google_firebase_android_app`.
```
16 changes: 13 additions & 3 deletions website/docs/d/firebase_android_app.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,25 @@ In addition to the arguments listed above, the following computed attributes are
* `id` - an identifier for the resource with format `{{name}}`

* `name` -
The fully qualified resource name of the App, for example:
The fully qualified resource name of the AndroidApp, for example:
projects/projectId/androidApps/appId

* `app_id` -
Immutable. The globally unique, Firebase-assigned identifier of the App.
Immutable. The globally unique, Firebase-assigned identifier of the AndroidApp.
This identifier should be treated as an opaque token, as the data format is not specified.

* `display_name` -
The user-assigned display name of the App.
The user-assigned display name of the AndroidApp.

* `package_name` -
The canonical package name of the Android app as would appear in the Google Play Developer Console.

* `sha1_hashes` -
The SHA1 certificate hashes for the AndroidApp.

* `sha256_hashes` -
The SHA256 certificate hashes for the AndroidApp.

* `etag` -
This checksum is computed by the server based on the value of other fields, and it may be sent
with update requests to ensure the client has an up-to-date value before proceeding.
20 changes: 17 additions & 3 deletions website/docs/r/firebase_android_app.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ resource "google_firebase_android_app" "basic" {
project = "my-project-name"
display_name = "Display Name Basic"
package_name = ""
sha1_hashes = ["2145bdf698b8715039bd0e83f2069bed435ac21c"]
sha256_hashes = ["2145bdf698b8715039bd0e83f2069bed435ac21ca1b2c3d4e5f6123456789abc"]
}
```

Expand All @@ -50,7 +52,7 @@ The following arguments are supported:

* `display_name` -
(Required)
The user-assigned display name of the App.
The user-assigned display name of the AndroidApp.


- - -
Expand All @@ -61,6 +63,14 @@ The following arguments are supported:
Immutable. The canonical package name of the Android app as would appear in the Google Play
Developer Console.

* `sha1_hashes` -
(Optional)
The SHA1 certificate hashes for the AndroidApp.

* `sha256_hashes` -
(Optional)
The SHA256 certificate hashes for the AndroidApp.

* `deletion_policy` -
(Optional)
(Optional) Set to `ABANDON` to allow the AndroidApp to be untracked from terraform state
Expand All @@ -78,13 +88,17 @@ In addition to the arguments listed above, the following computed attributes are
* `id` - an identifier for the resource with format `{{name}}`

* `name` -
The fully qualified resource name of the App, for example:
The fully qualified resource name of the AndroidApp, for example:
projects/projectId/androidApps/appId

* `app_id` -
The globally unique, Firebase-assigned identifier of the App.
The globally unique, Firebase-assigned identifier of the AndroidApp.
This identifier should be treated as an opaque token, as the data format is not specified.

* `etag` -
This checksum is computed by the server based on the value of other fields, and it may be sent
with update requests to ensure the client has an up-to-date value before proceeding.


## Timeouts

Expand Down