Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifying fields to DLP job trigger #13463

Conversation

modular-magician
Copy link
Collaborator

Adds field "identifyingAction" to DLP Jobs trigger API schema. This will match existing functionality in Cloud Console.

part of {#8838

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests. -- Did not run linter manually
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: Added field 'identifyingFields' to 'bigQueryOptions' for creating DLP jobs.

Derived from GoogleCloudPlatform/magic-modules#7037

* Add identifying fields to DLP job trigger

* Updated identifyingFields description.

* Removed unused variable and converted tabs to spaces in example file.

* Added DLP identifying fields update test

* Updated bigquery field name description

* Removed changes to terraform.yaml file

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 9fb464c into hashicorp:main Jan 11, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
@modular-magician modular-magician deleted the downstream-pr-d23c192b3d6f91055120d9e3500b9d3d7903ed23 branch November 17, 2024 01:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant