Stop acc test using authoritative IAM on shared KMS resources #13650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some Event Arc acceptance tests so they stop using an authoritative IAM binding on shared KMS resources.
I realised this was potentially a problem when I saw this test failing,
TestAccEventarcTrigger_channel
test in TPG night build, which made me look at the tests. I realised that the test uses an authoritative IAM binding on shared KMS resources and this could mean that tests interfere with each other.After this change, it'll match other acceptance tests that use bootstrapped KMS resources via data sources, e.g here in testAccComputeInstanceTemplate_sourceSnapshotEncryptionKey
This test used to use authoritative bindings on
tf-bootstrap-key1
andtf-bootstrap-key2
.Other test failures that may be resolved by this fix:
tf-bootstrap-key2
tf-bootstrap-key1
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7208