Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Jumbo Frames for VPC MTU #13674

Conversation

modular-magician
Copy link
Collaborator

Adjust description for VPC MTU to mention jumbo frames.
Currently, the field says the maximum is 1500 bytes which is not correct, but it's also not enforced. You can set it to 8896 bytes for jumbo frames and it will work, just the description says it's wrong.

The idea with this change is to convey the most important bits of information from here: https://cloud.google.com/vpc/docs/mtu

Since there's various cases to be covered I don't know what would be the best way to convey this in a short description, but here's my shot on that.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes). -> Very small change.
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests. -> No, first the link is broken, second that version of Ruby is too ancient to build properly. It's just a description change anyway, maybe a linter check would be nice but I can't get it working without Ruby. Or maybe I am just doing wrong, idk but it's just a description change.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). -> There's no new field.
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). -> Cannot run.
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed wrong maximum limit description for possible VPC MTUs

Derived from GoogleCloudPlatform/magic-modules#7221

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 97fb14b into hashicorp:main Feb 7, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant