Mention Jumbo Frames for VPC MTU #13674
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust description for VPC MTU to mention jumbo frames.
Currently, the field says the maximum is 1500 bytes which is not correct, but it's also not enforced. You can set it to 8896 bytes for jumbo frames and it will work, just the description says it's wrong.
The idea with this change is to convey the most important bits of information from here: https://cloud.google.com/vpc/docs/mtu
Since there's various cases to be covered I don't know what would be the best way to convey this in a short description, but here's my shot on that.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests. -> No, first the link is broken, second that version of Ruby is too ancient to build properly. It's just a description change anyway, maybe a linter check would be nice but I can't get it working without Ruby. Or maybe I am just doing wrong, idk but it's just a description change.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#7221