Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update maxItems #14041

Merged
merged 1 commit into from
Mar 20, 2023
Merged

update maxItems #14041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/7487.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
networkservices: updated maxItems to 25 for fields `expose_headers`,`allow_headers`, `request_header_to_remove`, `request_header_to_add`, `response_header_to_add` and `response_header_to_remove` of `google_network_services_edge_cache_service` and `request_headers_to_add` of `google_network_services_edge_cache_origin`
```
4 changes: 2 additions & 2 deletions google/resource_network_services_edge_cache_origin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ headers, for request handled by this origin.`,
Optional: true,
Description: `Describes a header to add.
You may add a maximum of 5 request headers.`,
You may add a maximum of 25 request headers.`,
MinItems: 1,
MaxItems: 5,
MaxItems: 25,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"header_name": {
Expand Down
12 changes: 6 additions & 6 deletions google/resource_network_services_edge_cache_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ to which you could add rules numbered from 6 to 8, 10 to 11, and 13 to 15 in the
Optional: true,
Description: `Describes a header to add.`,
MinItems: 1,
MaxItems: 5,
MaxItems: 25,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"header_name": {
Expand All @@ -290,7 +290,7 @@ to which you could add rules numbered from 6 to 8, 10 to 11, and 13 to 15 in the
Optional: true,
Description: `A list of header names for headers that need to be removed from the request prior to forwarding the request to the origin.`,
MinItems: 1,
MaxItems: 10,
MaxItems: 25,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"header_name": {
Expand All @@ -308,7 +308,7 @@ to which you could add rules numbered from 6 to 8, 10 to 11, and 13 to 15 in the
Response headers are only sent to the client, and do not have an effect on the cache serving the response.`,
MinItems: 1,
MaxItems: 5,
MaxItems: 25,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"header_name": {
Expand All @@ -335,7 +335,7 @@ Response headers are only sent to the client, and do not have an effect on the c
Optional: true,
Description: `A list of header names for headers that need to be removed from the request prior to forwarding the request to the origin.`,
MinItems: 1,
MaxItems: 10,
MaxItems: 25,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"header_name": {
Expand Down Expand Up @@ -729,7 +729,7 @@ This translates to the Access-Control-Allow-Credentials response header.`,
Type: schema.TypeList,
Optional: true,
Description: `Specifies the content for the Access-Control-Allow-Headers response header.`,
MaxItems: 5,
MaxItems: 25,
Elem: &schema.Schema{
Type: schema.TypeString,
},
Expand Down Expand Up @@ -763,7 +763,7 @@ This translates to the Access-Control-Allow-Origin response header.`,
Type: schema.TypeList,
Optional: true,
Description: `Specifies the content for the Access-Control-Allow-Headers response header.`,
MaxItems: 5,
MaxItems: 25,
Elem: &schema.Schema{
Type: schema.TypeString,
},
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/network_services_edge_cache_origin.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ The following arguments are supported:
* `request_headers_to_add` -
(Optional)
Describes a header to add.
You may add a maximum of 5 request headers.
You may add a maximum of 25 request headers.
Structure is [documented below](#nested_request_headers_to_add).


Expand Down