Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firebase_project to succeed on apply when the project already has firebase enabled #14121

Conversation

modular-magician
Copy link
Collaborator

fixes #14036

This fixes an issue where if a project already had Firebase enabled, terraform apply would fail with a 409 error. This was problematic because Firebase cannot be disabled, so while a user would normally expect to be able to apply -> destroy -> apply successfully, it would fail on this resource.

There was a workaround for users to import, but it was not ideal to force users to do this just for a single boolean setting.

Note that the proposed solution here matches how project_service currently works, where it first checks the API for the current state, and breaks early if there are no changes needed.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

firebase: fix `google_firebase_project` to succeed on apply when the project already has firebase enabled

Derived from GoogleCloudPlatform/magic-modules#7523

… firebase enabled (hashicorp#7523)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f512c2d into hashicorp:main Mar 28, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singleton resource google_firebase_project cannot easily be used in multiple configs
1 participant